[PATCH] D104699: [llvm-objdump] Print comments for the disassembled code

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion and one question. It looks to me like @MaskRay's comment is somewhat unrelated to this patch?



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1042
 
+static void emitEOLStuff(formatted_raw_ostream &FOS, const MCAsmInfo &MAI,
+                         const MCSubtargetInfo &STI, StringRef Comments,
----------------
"Stuff" sounds a little unprofessional, although I am struggling to come up with a good alternative!

Maybe `emitPostInstructionInfo`?


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1427
+
+          IP->setCommentStream(llvm::nulls());
 
----------------
I'm not really up-to-speed on a lot of the MC stuff, but is there a need to do this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104699/new/

https://reviews.llvm.org/D104699