[PATCH] D104483: Improve error handling in llvm-dwarfdump

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. If you want to bring back the test in a separate patch, that's absolutely fine (it sounds like there is some missing test coverage from what you said).



================
Comment at: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp:270
+  WithColor::error() << Prefix << ": " << toString(std::move(Err)) << "\n";
+  exit(1);  
 }
----------------
Nit: looks like there's some trailing whitespace here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104483/new/

https://reviews.llvm.org/D104483