[PATCH] D104698: [TableGen] Fix printing second PC-relative operand

Tue Jun 22 22:51:38 PDT 2021

ikudrin added inline comments.

================
Comment at: llvm/test/TableGen/AsmWriterPCRelOp.td:32
+
+// CHECK:      ArchInstPrinter::printInstruction
+// CHECK:      // bar, foo
----------------
MaskRay wrote:
> ikudrin wrote:
> > MaskRay wrote:
> > > `// CHECK-LABEL:  ArchInstPrinter::printInstruction(`
> > I am afraid I am not following you. What is the difference and how `CHECK-LABEL` can be useful in this case?
> When there are multiple functions, -LABEL patterns are matched first and they break the input into multiple regions. The FileCheck failing diagnostic can be slightly better with -LABEL. For this case I guess `-LABEL` may be an overkill. Do your original pattern is fine.
Thanks for explaining. I'll stick with my original check then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104698/new/

https://reviews.llvm.org/D104698