[PATCH] D104698: [TableGen] Fix printing second PC-relative operand

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 22 22:29:06 PDT 2021


ikudrin added inline comments.


================
Comment at: llvm/test/TableGen/AsmWriterPCRelOp.td:1
+// RUN: llvm-tblgen -gen-asm-writer -I %p/../../include %s > %t.log
+
----------------
MaskRay wrote:
> `%t.log` => `| FileCheck %s`
Thanks a lot! I'll fix that on commit.


================
Comment at: llvm/test/TableGen/AsmWriterPCRelOp.td:32
+
+// CHECK:      ArchInstPrinter::printInstruction
+// CHECK:      // bar, foo
----------------
MaskRay wrote:
> `// CHECK-LABEL:  ArchInstPrinter::printInstruction(`
I am afraid I am not following you. What is the difference and how `CHECK-LABEL` can be useful in this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104698/new/

https://reviews.llvm.org/D104698



More information about the llvm-commits mailing list