[llvm] 5cb5225 - [M68k] Refactor codegen patterns for logic operations and add tests for it
Jim Lin via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 22 22:22:59 PDT 2021
Author: Jim Lin
Date: 2021-06-23T13:25:24+08:00
New Revision: 5cb5225cf5c2adb55c55af842c4df5876e47169e
URL: https://github.com/llvm/llvm-project/commit/5cb5225cf5c2adb55c55af842c4df5876e47169e
DIFF: https://github.com/llvm/llvm-project/commit/5cb5225cf5c2adb55c55af842c4df5876e47169e.diff
LOG: [M68k] Refactor codegen patterns for logic operations and add tests for it
Refactor pat for and, or and xor operation and add missing tests for it
Reviewed By: myhsu
Differential Revision: https://reviews.llvm.org/D104626
Added:
llvm/test/CodeGen/M68k/Arith/bitwise.ll
Modified:
llvm/lib/Target/M68k/M68kInstrArithmetic.td
Removed:
################################################################################
diff --git a/llvm/lib/Target/M68k/M68kInstrArithmetic.td b/llvm/lib/Target/M68k/M68kInstrArithmetic.td
index 47deb59c7742..f65ad5729eb4 100644
--- a/llvm/lib/Target/M68k/M68kInstrArithmetic.td
+++ b/llvm/lib/Target/M68k/M68kInstrArithmetic.td
@@ -858,35 +858,23 @@ def : Pat<(sube i8 :$src, i8 :$opd), (SUBX8dd MxDRD8 :$src, MxDRD8 :$opd)>;
def : Pat<(sube i16:$src, i16:$opd), (SUBX16dd MxDRD16:$src, MxDRD16:$opd)>;
def : Pat<(sube i32:$src, i32:$opd), (SUBX32dd MxDRD32:$src, MxDRD32:$opd)>;
+multiclass BitwisePat<string INST, SDNode OP> {
+ // op reg, reg
+ def : Pat<(OP i8 :$src, i8 :$opd),
+ (!cast<MxInst>(INST#"8dd") MxDRD8 :$src, MxDRD8 :$opd)>;
+ def : Pat<(OP i16:$src, i16:$opd),
+ (!cast<MxInst>(INST#"16dd") MxDRD16:$src, MxDRD16:$opd)>;
+ def : Pat<(OP i32:$src, i32:$opd),
+ (!cast<MxInst>(INST#"32dd") MxDRD32:$src, MxDRD32:$opd)>;
+ // op reg, imm
+ def : Pat<(OP i8: $src, MximmSExt8 :$opd),
+ (!cast<MxInst>(INST#"8di") MxDRD8 :$src, imm:$opd)>;
+ def : Pat<(OP i16:$src, MximmSExt16:$opd),
+ (!cast<MxInst>(INST#"16di") MxDRD16:$src, imm:$opd)>;
+ def : Pat<(OP i32:$src, MximmSExt32:$opd),
+ (!cast<MxInst>(INST#"32di") MxDRD32:$src, imm:$opd)>;
+}
-// and reg, reg
-def : Pat<(and i8 :$src, i8 :$opd), (AND8dd MxDRD8 :$src, MxDRD8 :$opd)>;
-def : Pat<(and i16:$src, i16:$opd), (AND16dd MxDRD16:$src, MxDRD16:$opd)>;
-def : Pat<(and i32:$src, i32:$opd), (AND32dd MxDRD32:$src, MxDRD32:$opd)>;
-
-// and reg, imm
-def : Pat<(and i8: $src, MximmSExt8 :$opd), (AND8di MxDRD8 :$src, imm:$opd)>;
-def : Pat<(and i16:$src, MximmSExt16:$opd), (AND16di MxDRD16:$src, imm:$opd)>;
-def : Pat<(and i32:$src, MximmSExt32:$opd), (AND32di MxDRD32:$src, imm:$opd)>;
-
-
-// xor reg,reg
-def : Pat<(xor i8 :$src, i8 :$opd), (XOR8dd MxDRD8 :$src, MxDRD8 :$opd)>;
-def : Pat<(xor i16:$src, i16:$opd), (XOR16dd MxDRD16:$src, MxDRD16:$opd)>;
-def : Pat<(xor i32:$src, i32:$opd), (XOR32dd MxDRD32:$src, MxDRD32:$opd)>;
-
-// xor reg, imm
-def : Pat<(xor i8: $src, MximmSExt8 :$opd), (XOR8di MxDRD8 :$src, imm:$opd)>;
-def : Pat<(xor i16:$src, MximmSExt16:$opd), (XOR16di MxDRD16:$src, imm:$opd)>;
-def : Pat<(xor i32:$src, MximmSExt32:$opd), (XOR32di MxDRD32:$src, imm:$opd)>;
-
-
-// or reg, reg
-def : Pat<(or i8 :$src, i8 :$opd), (OR8dd MxDRD8 :$src, MxDRD8 :$opd)>;
-def : Pat<(or i16:$src, i16:$opd), (OR16dd MxDRD16:$src, MxDRD16:$opd)>;
-def : Pat<(or i32:$src, i32:$opd), (OR32dd MxDRD32:$src, MxDRD32:$opd)>;
-
-// or reg, imm
-def : Pat<(or i8: $src, MximmSExt8 :$opd), (OR8di MxDRD8 :$src, imm:$opd)>;
-def : Pat<(or i16:$src, MximmSExt16:$opd), (OR16di MxDRD16:$src, imm:$opd)>;
-def : Pat<(or i32:$src, MximmSExt32:$opd), (OR32di MxDRD32:$src, imm:$opd)>;
+defm : BitwisePat<"AND", and>;
+defm : BitwisePat<"OR", or>;
+defm : BitwisePat<"XOR", xor>;
diff --git a/llvm/test/CodeGen/M68k/Arith/bitwise.ll b/llvm/test/CodeGen/M68k/Arith/bitwise.ll
new file mode 100644
index 000000000000..d5fe191ab174
--- /dev/null
+++ b/llvm/test/CodeGen/M68k/Arith/bitwise.ll
@@ -0,0 +1,232 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=m68k-linux -verify-machineinstrs | FileCheck %s
+
+; op reg, reg
+
+define zeroext i8 @andb(i8 zeroext %a, i8 zeroext %b) nounwind {
+; CHECK-LABEL: andb:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.b (11,%sp), %d0
+; CHECK-NEXT: move.b (7,%sp), %d1
+; CHECK-NEXT: and.b %d0, %d1
+; CHECK-NEXT: move.l %d1, %d0
+; CHECK-NEXT: and.l #255, %d0
+; CHECK-NEXT: rts
+ %1 = and i8 %a, %b
+ ret i8 %1
+}
+
+define zeroext i16 @andw(i16 zeroext %a, i16 zeroext %b) nounwind {
+; CHECK-LABEL: andw:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.w (10,%sp), %d0
+; CHECK-NEXT: move.w (6,%sp), %d1
+; CHECK-NEXT: and.w %d0, %d1
+; CHECK-NEXT: move.l %d1, %d0
+; CHECK-NEXT: and.l #65535, %d0
+; CHECK-NEXT: rts
+ %1 = and i16 %a, %b
+ ret i16 %1
+}
+
+define i32 @andl(i32 %a, i32 %b) nounwind {
+; CHECK-LABEL: andl:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (8,%sp), %d1
+; CHECK-NEXT: move.l (4,%sp), %d0
+; CHECK-NEXT: and.l %d1, %d0
+; CHECK-NEXT: rts
+ %1 = and i32 %a, %b
+ ret i32 %1
+}
+
+define zeroext i8 @orb(i8 zeroext %a, i8 zeroext %b) nounwind {
+; CHECK-LABEL: orb:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.b (11,%sp), %d0
+; CHECK-NEXT: move.b (7,%sp), %d1
+; CHECK-NEXT: or.b %d0, %d1
+; CHECK-NEXT: move.l %d1, %d0
+; CHECK-NEXT: and.l #255, %d0
+; CHECK-NEXT: rts
+ %1 = or i8 %a, %b
+ ret i8 %1
+}
+
+define zeroext i16 @orw(i16 zeroext %a, i16 zeroext %b) nounwind {
+; CHECK-LABEL: orw:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.w (10,%sp), %d0
+; CHECK-NEXT: move.w (6,%sp), %d1
+; CHECK-NEXT: or.w %d0, %d1
+; CHECK-NEXT: move.l %d1, %d0
+; CHECK-NEXT: and.l #65535, %d0
+; CHECK-NEXT: rts
+ %1 = or i16 %a, %b
+ ret i16 %1
+}
+
+define i32 @orl(i32 %a, i32 %b) nounwind {
+; CHECK-LABEL: orl:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (8,%sp), %d1
+; CHECK-NEXT: move.l (4,%sp), %d0
+; CHECK-NEXT: or.l %d1, %d0
+; CHECK-NEXT: rts
+ %1 = or i32 %a, %b
+ ret i32 %1
+}
+
+define zeroext i8 @eorb(i8 zeroext %a, i8 zeroext %b) nounwind {
+; CHECK-LABEL: eorb:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.b (11,%sp), %d0
+; CHECK-NEXT: move.b (7,%sp), %d1
+; CHECK-NEXT: eor.b %d0, %d1
+; CHECK-NEXT: move.l %d1, %d0
+; CHECK-NEXT: and.l #255, %d0
+; CHECK-NEXT: rts
+ %1 = xor i8 %a, %b
+ ret i8 %1
+}
+
+define zeroext i16 @eorw(i16 zeroext %a, i16 zeroext %b) nounwind {
+; CHECK-LABEL: eorw:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.w (10,%sp), %d0
+; CHECK-NEXT: move.w (6,%sp), %d1
+; CHECK-NEXT: eor.w %d0, %d1
+; CHECK-NEXT: move.l %d1, %d0
+; CHECK-NEXT: and.l #65535, %d0
+; CHECK-NEXT: rts
+ %1 = xor i16 %a, %b
+ ret i16 %1
+}
+
+define i32 @eorl(i32 %a, i32 %b) nounwind {
+; CHECK-LABEL: eorl:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (8,%sp), %d1
+; CHECK-NEXT: move.l (4,%sp), %d0
+; CHECK-NEXT: eor.l %d1, %d0
+; CHECK-NEXT: rts
+ %1 = xor i32 %a, %b
+ ret i32 %1
+}
+
+; op reg, imm
+; For type i8 and i16, value is loaded from memory to avoid optimizing it to *.l
+
+define void @andib(i8* %a) nounwind {
+; CHECK-LABEL: andib:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %a0
+; CHECK-NEXT: move.b (%a0), %d0
+; CHECK-NEXT: and.b #18, %d0
+; CHECK-NEXT: move.b %d0, (%a0)
+; CHECK-NEXT: rts
+ %1 = load i8, i8* %a
+ %2 = and i8 %1, 18
+ store i8 %2, i8* %a
+ ret void
+}
+
+define void @andiw(i16* %a) nounwind {
+; CHECK-LABEL: andiw:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %a0
+; CHECK-NEXT: move.w (%a0), %d0
+; CHECK-NEXT: and.w #4660, %d0
+; CHECK-NEXT: move.w %d0, (%a0)
+; CHECK-NEXT: rts
+ %1 = load i16, i16* %a
+ %2 = and i16 %1, 4660
+ store i16 %2, i16* %a
+ ret void
+}
+
+define i32 @andil(i32 %a) nounwind {
+; CHECK-LABEL: andil:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %d0
+; CHECK-NEXT: and.l #305419896, %d0
+; CHECK-NEXT: rts
+ %1 = and i32 %a, 305419896
+ ret i32 %1
+}
+
+define void @orib(i8* %a) nounwind {
+; CHECK-LABEL: orib:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %a0
+; CHECK-NEXT: move.b (%a0), %d0
+; CHECK-NEXT: or.b #18, %d0
+; CHECK-NEXT: move.b %d0, (%a0)
+; CHECK-NEXT: rts
+ %1 = load i8, i8* %a
+ %2 = or i8 %1, 18
+ store i8 %2, i8* %a
+ ret void
+}
+
+define void @oriw(i16* %a) nounwind {
+; CHECK-LABEL: oriw:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %a0
+; CHECK-NEXT: move.w (%a0), %d0
+; CHECK-NEXT: or.w #4660, %d0
+; CHECK-NEXT: move.w %d0, (%a0)
+; CHECK-NEXT: rts
+ %1 = load i16, i16* %a
+ %2 = or i16 %1, 4660
+ store i16 %2, i16* %a
+ ret void
+}
+
+define i32 @oril(i32 %a) nounwind {
+; CHECK-LABEL: oril:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %d0
+; CHECK-NEXT: or.l #305419896, %d0
+; CHECK-NEXT: rts
+ %1 = or i32 %a, 305419896
+ ret i32 %1
+}
+
+define void @eorib(i8* %a) nounwind {
+; CHECK-LABEL: eorib:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %a0
+; CHECK-NEXT: move.b (%a0), %d0
+; CHECK-NEXT: eori.b #18, %d0
+; CHECK-NEXT: move.b %d0, (%a0)
+; CHECK-NEXT: rts
+ %1 = load i8, i8* %a
+ %2 = xor i8 %1, 18
+ store i8 %2, i8* %a
+ ret void
+}
+
+define void @eoriw(i16* %a) nounwind {
+; CHECK-LABEL: eoriw:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %a0
+; CHECK-NEXT: move.w (%a0), %d0
+; CHECK-NEXT: eori.w #4660, %d0
+; CHECK-NEXT: move.w %d0, (%a0)
+; CHECK-NEXT: rts
+ %1 = load i16, i16* %a
+ %2 = xor i16 %1, 4660
+ store i16 %2, i16* %a
+ ret void
+}
+
+define i32 @eoril(i32 %a) nounwind {
+; CHECK-LABEL: eoril:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: move.l (4,%sp), %d0
+; CHECK-NEXT: eori.l #305419896, %d0
+; CHECK-NEXT: rts
+ %1 = xor i32 %a, 305419896
+ ret i32 %1
+}
More information about the llvm-commits
mailing list