[PATCH] D97982: [MC] Introduce NeverAlign fragment type
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 22 19:21:16 PDT 2021
efriedma added a comment.
> NeverAlign functionality doesn't depend on the details of valid fragment caching. I've followed the debugger a bit more thoughtfully and I see that NeverAlign's fragment size is being updated on a relaxation of subsequent fragment here in MCAsmLayout::layoutFragment: https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCAssembler.cpp#L412.
Oh, hmm, I see. I guess in that case, it should be reliable; I'm okay with leaving it the way it is. Maybe add a comment to computeFragmentSize explaining that this is happening, though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97982/new/
https://reviews.llvm.org/D97982
More information about the llvm-commits
mailing list