[PATCH] D104721: [lld-macho] add tests for ICF, plus cleanups

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

Nice! Just one request: could we fix and test this too? https://reviews.llvm.org/D103292#inline-992625



================
Comment at: lld/test/MachO/icf.s:6
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin19.0.0 %t/abs.s -o %t/abs.o
+# RUN: %lld -pie -lSystem --icf=all -o %t/main %t/main.o %t/abs.o
 # RUN: llvm-objdump -d --syms %t/main | FileCheck %s
----------------
`-pie` shouldn't be necessary, `%lld` expands out to include a modern platform_version that implies PIE


================
Comment at: lld/test/MachO/icf.s:107
+
+### No fold: the absolute symbol reference differs
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104721/new/

https://reviews.llvm.org/D104721