[PATCH] D104752: [LLParser] Remove special handling for call address space

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

I'm confused by "The pointer address space of the callee should always match the specified addrspace". The addrspace on the call sounds like it's basically the "expected" addrspace and could affect lower of the call instruction itself. But the call operand might not be of that addrspace, whether it's a direct call's callee, or an indirect call's function pointer.



================
Comment at: llvm/lib/AsmParser/LLParser.cpp:1472
 Value *LLParser::checkValidVariableType(LocTy Loc, const Twine &Name, Type *Ty,
                                         Value *Val, bool IsCall) {
   if (Val->getType() == Ty)
----------------
IsCall isn't being used anymore


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104752/new/

https://reviews.llvm.org/D104752