[PATCH] D103857: [Attributor] Introduce a helper function to deal with undef + none

Tue Jun 22 14:48:41 PDT 2021

jdoerfert added inline comments.

================
Comment at: llvm/test/Transforms/Attributor/nocapture-2.ll:214
 ; CHECK-LABEL: define {{[^@]+}}@scc_A
-; CHECK-SAME: (i32* nofree readnone returned dereferenceable_or_null(4) "no-capture-maybe-returned" [[A:%.*]]) #[[ATTR2:[0-9]+]] {
+; CHECK-SAME: (i32* nofree readnone dereferenceable_or_null(4) "no-capture-maybe-returned" [[A:%.*]]) #[[ATTR2:[0-9]+]] {
 ; CHECK-NEXT:  entry:
----------------
jdoerfert wrote:
> kuter wrote:
> > why is returned missing here ?
> Idk. I'll take a look.
I'd suggest that we look into this after D103860 landed. A lot of the aareturnedvalue handling is going away with that one. The gist here is that we can now look through the casts in scc_A, scc_B, and scc_C and therefore follow the returned call through the argument. This confuses the "unique return" logic.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103857/new/

https://reviews.llvm.org/D103857