[PATCH] D104740: [OpaquePtr] Support call instruction

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:1483
+  };
+  if (CheckType(Ty))
     return Val;
----------------
aeubanks wrote:
> if we have an opaque pointer of a wrong address space, we could get past the first `CheckType()`, then call `getElementType()` on the opaque pointer type below
I've changed it to use getWithSamePointeeType() instead. It's not possible to actually trigger this case right now, because `Ty` currently can't be opaque (would need D103503). Only `ValTy` can be opaque.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104740/new/

https://reviews.llvm.org/D104740