[PATCH] D95339: [RFC][test] Adapt debug-info lit framework for more general purposes - part 1

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 22 13:02:31 PDT 2021


dblaikie added a comment.

In D95339#2833613 <https://reviews.llvm.org/D95339#2833613>, @mehdi_amini wrote:

> In D95339#2832498 <https://reviews.llvm.org/D95339#2832498>, @jhenderson wrote:
>
>> In D95339#2831897 <https://reviews.llvm.org/D95339#2831897>, @mehdi_amini wrote:
>>
>>> Seems like there are only a few line changed other than the renaming? What kind of review is needed here? Just an agreement on the principle of moving these? I think it should be someone having a stake in the debug-info tests to give some sort of approval here.
>>
>> Yeah, exactly. I've not had any positive confirmation that people are happy with the overall idea.
>
> @aprantl @dblaikie maybe?

Yeah, generally I was leaving this up to @aprantl or whoever else has some more conext/history/ownership over the existing debug-info-tests repository.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95339/new/

https://reviews.llvm.org/D95339



More information about the llvm-commits mailing list