[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

Tue Jun 22 12:55:48 PDT 2021

dblaikie added a subscriber: aaron.ballman.
dblaikie added a comment.

In D104342#2834119 <https://reviews.llvm.org/D104342#2834119>, @nickdesaulniers wrote:

> In D104342#2831738 <https://reviews.llvm.org/D104342#2831738>, @dblaikie wrote:
>
>>> In D104342#2831717 <https://reviews.llvm.org/D104342#2831717>, @dblaikie wrote:
>>>
>>>> Probably worth at least writing up the risk/instability in the docs for the warning (in clang) and attribute (in llvm). (don't mind if that's in this patch or a follow-up).
>
> I would think https://clang.llvm.org/docs/DiagnosticsReference.html#wframe-larger-than would be an appropriate place to document this for `-Wframe-larger-than=`, but it seems this whole page is generated via TableGen. It's not clear to me how we could insert such a note.

Yeah, I don't think we have a way to add more verbose/custom documentation for diagnostics. (@aaron.ballman might have some ideas)

> Langref changes: https://reviews.llvm.org/D104736.

Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104342/new/

https://reviews.llvm.org/D104342