[compiler-rt] ae10939 - Revert "[compiler-rt] Make use of undefined symbols configurable"

[Nikita Popov via llvm-commits]

Author: Nikita Popov
Date: 2021-06-22T21:20:20+02:00
New Revision: ae1093921fc83294a310cd6e7bb721970754ddcb

URL: https://github.com/llvm/llvm-project/commit/ae1093921fc83294a310cd6e7bb721970754ddcb
DIFF: https://github.com/llvm/llvm-project/commit/ae1093921fc83294a310cd6e7bb721970754ddcb.diff

LOG: Revert "[compiler-rt] Make use of undefined symbols configurable"

This reverts commit ed7086ad46f99f639b85ea6c8bda7c1a71be7c53.
This reverts commit b9792638b0bfb308e0c7c125ac78f4ebf910c11b.

This breaks cmake with message:

    CMake Error at llvm-project/compiler-rt/CMakeLists.txt:449:
      Parse error.  Expected "(", got newline with text "

Added: 
    

Modified: 
    compiler-rt/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/compiler-rt/CMakeLists.txt b/compiler-rt/CMakeLists.txt
index c961c7f834bf..5d0e617a5406 100644
--- a/compiler-rt/CMakeLists.txt
+++ b/compiler-rt/CMakeLists.txt
@@ -437,18 +437,10 @@ else()
 endif()
 
 append_list_if(COMPILER_RT_HAS_LIBC c SANITIZER_COMMON_LINK_LIBS)
-if("${CMAKE_SYSTEM_NAME}" STREQUAL "Fuchsia")
-  list(APPEND SANITIZER_COMMON_LINK_LIBS zircon)
-endif()
 
 if("${CMAKE_SYSTEM_NAME}" STREQUAL "Fuchsia")
-  set(SANITIZER_NO_UNDEFINED_SYMBOLS_DEFAULT ON)
-else()
-  set(SANITIZER_NO_UNDEFINED_SYMBOLS_DEFAULT OFF)
-endif
-option(SANITIZER_NO_UNDEFINED_SYMBOLS "Report error on unresolved symbol references" ${SANITIZER_NO_UNDEFINED_SYMBOLS_DEFAULT})
-if (SANITIZER_NO_UNDEFINED_SYMBOLS)
   list(APPEND SANITIZER_COMMON_LINK_FLAGS -Wl,-z,defs)
+  list(APPEND SANITIZER_COMMON_LINK_LIBS zircon)
 endif()
 
 # TODO: COMPILER_RT_COMMON_CFLAGS and COMPILER_RT_COMMON_LINK_FLAGS are