[PATCH] D104529: [LLD] [COFF] Avoid doing repeated fuzzy symbol lookup for each iteration. NFC.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 22 12:04:35 PDT 2021
rnk added inline comments.
================
Comment at: lld/COFF/Driver.cpp:564
unmangled->weakAlias = symtab->addUndefined(mangled->getName());
return mangled->getName();
}
----------------
I think I see the issue: suppose there are two rounds of symbol resolution. This function will be called twice, and on the second call, it returns a different result to the caller. The result of this function is used to populate Export.symbolName, which is used to produce an import library, and that's what changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104529/new/
https://reviews.llvm.org/D104529
More information about the llvm-commits
mailing list