[PATCH] D104606: llvm-diff: add support for diffing the callbr instruction

[Bill Wendling via Phabricator via llvm-commits]

void updated this revision to Diff 353735.
void added a comment.

Rebase with top-of-tree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104606/new/

https://reviews.llvm.org/D104606

Files:
  llvm/test/tools/llvm-diff/callbr.ll
  llvm/tools/llvm-diff/DifferenceEngine.cpp


Index: llvm/tools/llvm-diff/DifferenceEngine.cpp
===================================================================
--- llvm/tools/llvm-diff/DifferenceEngine.cpp
+++ llvm/tools/llvm-diff/DifferenceEngine.cpp
@@ -287,6 +287,27 @@
       }
       return false;
 
+    } else if (isa<CallBrInst>(L)) {
+      const CallBrInst &LI = cast<CallBrInst>(*L);
+      const CallBrInst &RI = cast<CallBrInst>(*R);
+      if (LI.getNumIndirectDests() != RI.getNumIndirectDests()) {
+        if (Complain)
+          Engine.log("callbr # of indirect destinations differ");
+        return true;
+      }
+
+      // Perform the "try unify" step so that we can equate the indirect
+      // destinations before checking the call site.
+      for (unsigned I = 0; I < LI.getNumIndirectDests(); I++)
+        tryUnify(LI.getIndirectDest(I), RI.getIndirectDest(I));
+
+      if (diffCallSites(LI, RI, Complain))
+        return true;
+
+      if (TryUnify)
+        tryUnify(LI.getDefaultDest(), RI.getDefaultDest());
+      return false;
+
     } else if (isa<BranchInst>(L)) {
       const BranchInst *LI = cast<BranchInst>(L);
       const BranchInst *RI = cast<BranchInst>(R);
Index: llvm/test/tools/llvm-diff/callbr.ll
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-diff/callbr.ll
@@ -0,0 +1,39 @@
+; RUN: not llvm-diff %s %s 2>&1 | FileCheck %s
+
+define void @foo() {
+entry:
+  callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %return), i8* blockaddress(@foo, %t_no))
+          to label %asm.fallthrough [label %return, label %t_no]
+
+asm.fallthrough:
+  br label %return
+
+t_no:
+  br label %return
+
+return:
+  ret void
+}
+
+; CHECK:      in function bar:
+; CHECK-NOT:  in function foo:
+; CHECK-NEXT:  in block %entry:
+; CHECK-NEXT:    >   callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %return))
+; CHECK-NEXT:          to label %asm.fallthrough [label %return, label %t_no]
+; CHECK-NEXT:    <   callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %return))
+; CHECK-NEXT:          to label %asm.fallthrough [label %return, label %t_no]
+
+define void @bar() {
+entry:
+  callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %return))
+          to label %asm.fallthrough [label %return, label %t_no]
+
+asm.fallthrough:
+  br label %return
+
+t_no:
+  br label %return
+
+return:
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104606.353735.patch
Type: text/x-patch
Size: 2604 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210622/591b1971/attachment.bin>