[PATCH] D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 22 11:17:30 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13259
+
+  auto isFoldableFMUL = [isContractableFMUL, isReassociable](SDValue N) {
+    return isContractableFMUL(N) && isReassociable(N.getNode());
----------------
`foldable` is a rather generic and widely used term.
I'd suggest `isContractableAndReassociableFMUL()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104723/new/

https://reviews.llvm.org/D104723



More information about the llvm-commits mailing list