[PATCH] D104431: [lld] Add lto-cspgo-warn-mismatch option for COFF

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

A few high level comments/questions based on the discussion:

- Is there a clang option? I thought there was but can't find one now. We should probably take the same approach here for the linker (external option vs use of the internal llvm option, similar name).
- Since this is affecting regular PGO mismatches (via NoPGOWarnMismatch) and not just CSPGO the name should presumably not mention the "CS" part.
- Please add for ELF as well in the same patch - should be straightfoward.
- Tests needed.

We should probably settle the first question above first though - i.e. is there a clang driver option and if not, perhaps the internal option should be used via the linker as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104431/new/

https://reviews.llvm.org/D104431