[PATCH] D104589: [llvm-rc] Don't rewrite the arch in the default triple unless necessary

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

The idea looks fine.  Just a couple inline questions.



================
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:148
 
-Triple::ArchType getDefaultArch(Triple::ArchType Arch) {
+bool isUsableDefaultArch(Triple::ArchType Arch) {
   switch (Arch) {
----------------
Should this be just `isUsableArch`?  It doesn't seem like `Default` is relevant in this new formulation.


================
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:184
+  if (!isUsableDefaultArch(T.getArch()))
+    T.setArch(getDefaultFallbackArch());
   if (T.isWindowsGNUEnvironment())
----------------
Is there a guarantee that the fallback will be usable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104589/new/

https://reviews.llvm.org/D104589