[PATCH] D104718: [OpaquePtr] Support changing load type in InstCombine

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 22 09:06:09 PDT 2021


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

lgtm with nit



================
Comment at: llvm/lib/IR/Type.cpp:728
 
-PointerType *Type::getPointerTo(unsigned addrs) const {
-  return PointerType::get(const_cast<Type*>(this), addrs);
+PointerType *Type::getPointerTo(unsigned AddrSpace) const {
+  // Pointer to opaque pointer is opaque pointer.
----------------
probably worth putting a comment in the header that this method should be removed after the opaque pointer transition


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104718/new/

https://reviews.llvm.org/D104718



More information about the llvm-commits mailing list