[PATCH] D104668: [OpaquePtr] Handle addrspacecasts in InstCombine

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

lgtm with one nit



================
Comment at: llvm/include/llvm/IR/DerivedTypes.h:701
+  /// pointers are considered to have the same element type, while an opaque
+  /// and a non-opaque pointer have different element types.
+  bool hasSameElementTypeAs(PointerType *Other) {
----------------
could you add a note that this is purely for the opaque pointer transition


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104668/new/

https://reviews.llvm.org/D104668