[PATCH] D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked 3 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1935-1936
+
+  // Since the new C++ runtime will be restoring vector registers on unwind, we
+  // need to emit a dumy eh info when there are VRs saved.
+  if (!TargetLoweringObjectFileXCOFF::ShouldEmitEHBlock(MF) &&
----------------
jasonliu wrote:
> clang-format the suggested comment.
> 
> I would also suggest to put a comment in AIXException::endFunction to indicate there is another place that would emit this eh info table structure. In case someone needs to update this structure, they would know they need to update in both places.
thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103651/new/

https://reviews.llvm.org/D103651