[PATCH] D104634: [SCEV] Generalize MatchBinaryAddToConst to support non-add expressions.

Tue Jun 22 06:37:20 PDT 2021

fhahn added a comment.

> For an optional follow up change, I believe we can avoid checking the wrap flags for one operand, if C1 and C2 share the same sign.

Thanks, I'll try to look into this as a follow-up.

In D104634#2830649 <https://reviews.llvm.org/D104634#2830649>, @mkazantsev wrote:

> Ok, thanks for clarification. With this clarification looks fine. Please give me some time to run it through my fuzz corps.

Thanks for the testing ahead of landing! I'll wait a day or so with landing, in case one of my earlier patches surfaces any issues.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104634/new/

https://reviews.llvm.org/D104634