[PATCH] D103225: [AMDGPU] Replace non-kernel function uses of LDS globals by pointers.
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 22 05:24:19 PDT 2021
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp:51
+
+ for (scc_iterator<CallGraphNode *> I = scc_begin(CGN); !I.isAtEnd(); ++I) {
+ const std::vector<CallGraphNode *> &SCC = *I;
----------------
foad wrote:
> There is no need to find strongly connected components. This should use a df_iterator instead.
D104704
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103225/new/
https://reviews.llvm.org/D103225
More information about the llvm-commits
mailing list