[PATCH] D103974: [llvm-objdump] Add testing for --print-imm-hex, --headers, --section-headers and --private-headers

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo updated this revision to Diff 353594.
gbreynoo marked 9 inline comments as done.
gbreynoo added a comment.

I followed jhendersons suggestions regarding whitespace, the YAML in `private-headers.test` and adding a test `program-headers.test` based off the equivalent `llvm-readobj` test. With this last point I found the following:

- Unlike `llvm-readobj`, ARM and MIPs specific program header type's are not printed.
- Unlike `llvm-readobj`, there is no warning when a program interpreter name is non-null-terminated or when PT_INTERP has an offset that goes past the end of the file.
- `llvm-objdump` has test cases here when a warning and error with effectively the same message are output together. This is due to the call to `printELFFileHeader` returning early in these cases with a warning, but the following call to `printELFDynamicSection` ending with an error for the same issue.

Regarding the three points above, I presume they are not expected behaviour and so will create bugzilla tickets for them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103974/new/

https://reviews.llvm.org/D103974

Files:
  llvm/test/tools/llvm-objdump/ELF/private-headers.test
  llvm/test/tools/llvm-objdump/ELF/program-headers.test
  llvm/test/tools/llvm-objdump/X86/print-imm-hex.s
  llvm/test/tools/llvm-objdump/section-headers.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103974.353594.patch
Type: text/x-patch
Size: 20888 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210622/43e9a9b3/attachment.bin>