[PATCH] D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR
Peter Waller via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 22 03:29:40 PDT 2021
peterwaller-arm added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4743
+ SDValue SubVecPtr =
+ TLI.getVectorElementPointer(DAG, StackPtr, VecVT, ScaledIdx, Clamp);
+ Store = DAG.getStore(Store, dl, SubVec, SubVecPtr, PtrInfo, SmallestAlign);
----------------
My thinking here is that the clamping logic of getVectorElementPointer isn't appropriate for what is needed here. It's necessary to ensure the upper element of the inserted fixed-width vector fits into the scalable vector. getVectorElementPointer is effectively only forcing that the first element is in bounds, but it's the last element which matters.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102766/new/
https://reviews.llvm.org/D102766
More information about the llvm-commits
mailing list