[PATCH] D104659: [ARM] Limit v6m unrolling with multiple live outs

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:2195-2196
+  // be live out of the loop, reducing the default unroll count if more than 1
+  // value is needed.  In the long run, all of this should be being learnt by a
+  // machine.
+  unsigned UnrollCount = 4;
----------------
> In the long run, all of this should be being learnt by a machine.

:-)


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:2209
+      });
+      ExitingValues = ExitingValues < LiveOuts ? LiveOuts : ExitingValues;
+    }
----------------
I was wondering if this is right. I.e., we are not e.g. accumulating the exit values, or taking a maximum, or something like that, if I am not mistaken. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104659/new/

https://reviews.llvm.org/D104659