[PATCH] D104642: [AIX][XCOFF] Enable support for 64 bit symbol table writing

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 22 01:44:49 PDT 2021


jhenderson added a comment.

In D104642#2832572 <https://reviews.llvm.org/D104642#2832572>, @MaryamBen wrote:

> In D104642#2832519 <https://reviews.llvm.org/D104642#2832519>, @jhenderson wrote:
>
>> Test case?
>
> There is no way to run tests for 64-bit since the writeRelocation isn't implemented.
>
>   void XCOFFObjectWriter::writeRelocation(XCOFFRelocation Reloc,
>                                           const ControlSection &CSection) {
>     if (TargetObjectWriter->is64Bit())
>       report_fatal_error("64-bit XCOFF object files are not supported yet.");

Surely you could have a test case without any relocations?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104642/new/

https://reviews.llvm.org/D104642



More information about the llvm-commits mailing list