[PATCH] D104642: [AIX][XCOFF] Enable support for 64 bit symbol table writing
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jun 22 01:05:57 PDT 2021
    
    
  
jhenderson added a comment.
Test case?
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:584
+  if (TargetObjectWriter->is64Bit())
+     W.write<uint32_t>(Strings.getOffset(SymbolName));
+  else {
----------------
Please run clang-format.
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:603
+    W.write<uint64_t>(CSectionRef.Address + SymbolOffset);
+  // Name or string table offset
   writeSymbolName(SymbolRef.getSymbolTableName());
----------------
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104642/new/
https://reviews.llvm.org/D104642
    
    
More information about the llvm-commits
mailing list