[PATCH] D104365: [FuncSpec] Enabling specializing direct constant

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

> First of all, because we first need to know what the increase is. Second, when we know the increase, only then we can say if it should or not.
> Repeating what I said earlier, I think the order of events should be this: I would like to see more fine-grain stats and options, compile time data for a few different code bases, and then a discussion on the cost-model before we add this.

Agreed. Although it seems like that the process of improving in this way would be much slower than I thought before, it would be much more stable. I could understand it.

> thus, if you do this under an option that is off by default first, I have no problems at all with adding thi, while perhaps in the mean time you work on getting numbers and the cost-model.

Would do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104365/new/

https://reviews.llvm.org/D104365