[PATCH] D104613: [llvm-readobj][XCOFF] Add support for printing the String Table.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:190
 
+Expected<DenseMap<uint64_t, StringRef>>
+XCOFFObjectFile::getStringTable() const {
----------------
Since we are modifying `lib/Object/XCOFFObjectFile.cpp` and this function may return an error, I think we need to write unittest for this function. What do you think, @jhenderson ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104613/new/

https://reviews.llvm.org/D104613