[PATCH] D104078: [Remarks] Make memsize remarks report as an analysis, not a missed opportunity.

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/Transforms/Utils/MemoryOpRemark.h:59
+
+  enum RemarkStyle { RS_Missed, RS_Analysis };
+  virtual RemarkStyle remarkStyle() const { return RS_Analysis; }
----------------
Can we reuse `enum DiagnosticKind` from DiagnosticInfo.h?

```
  DK_OptimizationRemarkMissed,
  DK_OptimizationRemarkAnalysis,
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104078/new/

https://reviews.llvm.org/D104078