[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 21 14:51:10 PDT 2021


davidxl added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:124
+    // On WIN64, CountersDelta is truncated as well, so no need for signext.
+    uint64_t *SrcCounters =
+        SrcCountersStart +
----------------
The code to compute the relative counter offset is pretty confusing. Perhaps add more comments on the math behind it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104556/new/

https://reviews.llvm.org/D104556



More information about the llvm-commits mailing list