[PATCH] D104641: [LICM] Strip context sensitive attributes after call hoisting

Mon Jun 21 13:43:33 PDT 2021

asbirlea added a comment.

It may be too much to overload the existing APIs, since this applies only to calls (e.g. in GVNHoist, metadata is dropped for geps, this would be unnecessary). So either doing the two calls independently as in this patch or add another API that does both. 
I don't have strong opinions either way.

Is it possible this patch applies at the call in `SimplifyCFG.cpp:1092` and `:2487` and at `hoistAllInstructionsInto` in `Local.cpp` (also used by SimplifyCFG)? If the number of use cases is large enough, an API with both might make sense.

Side note, I believe there are cases where metadata must be dropped for correctness as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104641/new/

https://reviews.llvm.org/D104641