[PATCH] D104584: [SampleFDO] Make FSDiscriminator flag part of function parameters

[Rong Xu via llvm-commits]

On Mon, Jun 21, 2021 at 12:25 PM Wenlei He via Phabricator <
reviews at reviews.llvm.org> wrote:

> wenlei added inline comments.
>
>
> ================
> Comment at:
> llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h:284
> +  if (EnableFSDiscriminator)
> +    Discriminator = DIL->getDiscriminator();
> +  else
> ----------------
> wenlei wrote:
> > This seems to be the most important change in the patch? :)
> Pasting email reply from Rong:
>
> > No. It's actually NFC in this patch.  This is because this code is
> currently only called by ProfileLoader. In ProfileLoader,
> getDiscriminator() is the same as getBaseDiscriminator() because only base
> discriminator is used.
> > This only matters for FS-ProfileLoader.
>
> Just to make sure I understand this correctly, this path will be shared
> between base/current profile loader and fs-profile loader, right?

Yes. That is correct.
This is NFC for base profile_loader, but this is not NFC for fs-profile.
Sorry if I confused you about this.


>
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D104584/new/
>
> https://reviews.llvm.org/D104584
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210621/03a046a8/attachment.html>