[PATCH] D104229: [flang][docs] Add documentation for the new Flang driver

Mon Jun 21 10:13:31 PDT 2021

richard.barton.arm added inline comments.

================
Comment at: flang/docs/FlangDriver.md:69
+```
+flang -ccc-print-phases -c file.f
+         +- 0: input, "file.f", f95-cpp-input
----------------
I thought this was wrong when I first saw it, but I can reproduce. What's flang-new doing here then? I thought there was no support for these phases in flang yet?

================
Comment at: flang/docs/FlangDriver.md:152
+When adding a compiler driver option (i.e. an option that contains
+`FlangOption` among its `Flags`) that you also intend to be understood by  for
+the frontend, make sure that it is either forwarded to `flang -fc1` or
----------------

================
Comment at: flang/docs/FlangDriver.md:44
+
+Internally, a `clangDriver` based compiler driver works by creating actions
+that correspond to various compiler phases (e.g. `PreprocessJobClass`,
----------------
awarzynski wrote:
> richard.barton.arm wrote:
> > I think a diagram would really help explain this part.
> I find the output generated with `-ccc-print-phases` more helpful than any of the diagrams that I've generated so far :) Let me try that instead.
LGTM

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104229/new/

https://reviews.llvm.org/D104229