[PATCH] D104618: [LoopDeletion] Exploit undef when symbolically executing 1st iteration

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 21 09:20:19 PDT 2021


reames added a comment.

I would suggest splitting this into two patches.  The "ignore undef input in phi" is safe, and commonly done across the optimizer.  The "branch on undef" is tricky.  Just from a risk management perspective, I think it makes sense to split them into separate changes.

If you want to split, you can consider this an LGTM for the "ignore undef input in phi" part, and then continue this review for the "branch on undef" part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104618/new/

https://reviews.llvm.org/D104618



More information about the llvm-commits mailing list