[PATCH] D104584: [SampleFDO] Make FSDiscriminator flag part of function parameters

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2203-2210
 unsigned DILocation::getBaseDiscriminator() const {
-  return getBaseDiscriminatorFromDiscriminator(getDiscriminator());
+  return getBaseDiscriminatorFromDiscriminator(getDiscriminator(),
+                                               EnableFSDiscriminator);
+}
+unsigned DILocation::getBaseDiscriminator(bool IsFSDiscriminator) const {
+  return getBaseDiscriminatorFromDiscriminator(getDiscriminator(),
+                                               IsFSDiscriminator);
----------------
Can we just use "unsigned DILocation::getBaseDiscriminator(bool IsFSDiscriminator = false)" or we still need the two API?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104584/new/

https://reviews.llvm.org/D104584