[PATCH] D104080: [LLD][LLVM] CG Graph profile using relocations

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/call-graph-profile-section.yaml:48
+# BASIC32:       EntrySize: 12
+# BASIC-NEXT:       SectionData (
+# BASIC64-LE:      0000: 00000000 00000000 00000000 01000000
----------------
jhenderson wrote:
> Don't check the SectionData of the relocation section. In fact, don't bother having a relocation section at all - this isn't relevant to how yaml2obj generates the call graph section.
I think relocation is needed in this case. Check is done with llvm-readobj --cg-profile. Unless that flag can be dropped?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104080/new/

https://reviews.llvm.org/D104080