[PATCH] D103655: [AMDGPU] Handle constant LDS uses from different kernels

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 01:44:35 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:295
       if (F) {
+        // Replace all constant uses with instructions if they belong to the
+        // current kernel.
----------------
There is no need to create any Instructions. You are just replacing one Constant (GV) with another (GEP).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103655/new/

https://reviews.llvm.org/D103655



More information about the llvm-commits mailing list