[PATCH] D104316: [AMDGPU] Propagate LDS align into to instructions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 12:20:43 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:339
+
+  void refineUsesAlignment(Value *Ptr, Align A, const DataLayout &DL,
+                       unsigned MaxDepth = 5) {
----------------
arsenm wrote:
> This looks like you are reinventing getOrEnforceKnownAlignment
I'm not sure why you need to do this. SelectionDAG does already try to increase the alignment after this point


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104316/new/

https://reviews.llvm.org/D104316



More information about the llvm-commits mailing list