[PATCH] D104148: [LoopUtils] Fix incorrect RT check bounds for loop-invariant mem accesses

Mindong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 20 20:31:44 PDT 2021


mdchen updated this revision to Diff 353265.
mdchen retitled this revision from "[LoopUtils] Fix incorrect runtime checks" to "[LoopUtils] Fix incorrect RT check bounds for loop-invariant mem accesses".
mdchen edited the summary of this revision.
mdchen added a comment.

Updated previous failed x86 cases.

As a explanation for the changes, I think it's unnecessary to deal with loop-invariant cases separately
in `expandBounds`. Instead, we should assign the correct left closed right open range to invariant
accesses in `RuntimePointerChecking::insert`. Please correct me if I missed something, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104148/new/

https://reviews.llvm.org/D104148

Files:
  llvm/lib/Analysis/LoopAccessAnalysis.cpp
  llvm/lib/Transforms/Utils/LoopUtils.cpp
  llvm/test/Transforms/LoopVectorize/X86/invariant-store-vectorization.ll
  llvm/test/Transforms/LoopVectorize/X86/uniform_mem_op.ll
  llvm/test/Transforms/LoopVectorize/invariant-store-vectorization.ll
  llvm/test/Transforms/LoopVectorize/multiple-strides-vectorization.ll
  llvm/test/Transforms/LoopVectorize/pr47343-expander-lcssa-after-cfg-update.ll
  llvm/test/Transforms/LoopVectorize/pr50686.ll
  llvm/test/Transforms/LoopVersioningLICM/loopversioningLICM1.ll
  llvm/test/Transforms/LoopVersioningLICM/loopversioningLICM2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104148.353265.patch
Type: text/x-patch
Size: 40878 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210621/627abc99/attachment-0001.bin>


More information about the llvm-commits mailing list