[PATCH] D104503: [SCEV] Don't require dominance ordering of add/mul/min/max expressions

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

There are two relevant questions:

1. Does SCEV do something reasonable with such an expression?  I mean, you obviously can't expand it; there isn't any viable insertion point.  More generally, I'm not sure it's meaningful; even if we drop the assertions, it's not clear what the result is supposed to represent. If we want to support "subtracting" two addrecs to do dependency analysis, we should probably add a dedicated method, which returns something that isn't a regular SCEV expression.
2. Why is SCEVAA trying to construct such an expression?  AliasAnalysis::alias() doesn't make any sense if there isn't a dominance relationship between the two pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104503/new/

https://reviews.llvm.org/D104503