[lld] 89e66a3 - [ELF] Delete --no-cref which does not exist in GNU ld

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2021-06-20T14:28:56-07:00
New Revision: 89e66a3ab3b2958285842ed3705b2264c0f67473

URL: https://github.com/llvm/llvm-project/commit/89e66a3ab3b2958285842ed3705b2264c0f67473
DIFF: https://github.com/llvm/llvm-project/commit/89e66a3ab3b2958285842ed3705b2264c0f67473.diff

LOG: [ELF] Delete --no-cref which does not exist in GNU ld

Also delete the single dash form which does not appear to be used.

Added: 
    

Modified: 
    lld/ELF/Driver.cpp
    lld/ELF/Options.td
    lld/test/ELF/cref.s
    lld/test/ELF/just-symbols-cref.s

Removed: 
    


################################################################################
diff  --git a/lld/ELF/Driver.cpp b/lld/ELF/Driver.cpp
index c3adeeca6e465..b654bb86d6806 100644
--- a/lld/ELF/Driver.cpp
+++ b/lld/ELF/Driver.cpp
@@ -964,7 +964,7 @@ static void readConfigs(opt::InputArgList &args) {
       args.hasFlag(OPT_check_sections, OPT_no_check_sections, true);
   config->chroot = args.getLastArgValue(OPT_chroot);
   config->compressDebugSections = getCompressDebugSections(args);
-  config->cref = args.hasFlag(OPT_cref, OPT_no_cref, false);
+  config->cref = args.hasArg(OPT_cref);
   config->defineCommon = args.hasFlag(OPT_define_common, OPT_no_define_common,
                                       !args.hasArg(OPT_relocatable));
   config->optimizeBBJumps =

diff  --git a/lld/ELF/Options.td b/lld/ELF/Options.td
index 8af1255eb6efe..590a2ca61fa55 100644
--- a/lld/ELF/Options.td
+++ b/lld/ELF/Options.td
@@ -126,9 +126,7 @@ def color_diagnostics_eq: J<"color-diagnostics=">,
   HelpText<"Use colors in diagnostics (default: auto)">,
   MetaVarName<"[auto,always,never]">;
 
-defm cref: B<"cref",
-    "Output cross reference table",
-    "Do not output cross reference table">;
+def cref: FF<"cref">, HelpText<"Output cross reference table">;
 
 defm define_common: B<"define-common",
     "Assign space to common symbols",

diff  --git a/lld/test/ELF/cref.s b/lld/test/ELF/cref.s
index a5ad748983332..30989205874fe 100644
--- a/lld/test/ELF/cref.s
+++ b/lld/test/ELF/cref.s
@@ -7,7 +7,7 @@
 // RUN: llvm-ar rcs %t.a %ta.o
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t3.o
 // RUN: ld.lld -shared -o %t1.so %t1.o
-// RUN: ld.lld -o /dev/null %t1.so %t2.o %t3.o %t.a -gc-sections -cref | FileCheck -strict-whitespace %s
+// RUN: ld.lld -o /dev/null %t1.so %t2.o %t3.o %t.a --gc-sections --cref | FileCheck -strict-whitespace %s
 
 //      CHECK: Symbol                                            File
 // CHECK-NEXT: foo                                               {{.*}}1.so

diff  --git a/lld/test/ELF/just-symbols-cref.s b/lld/test/ELF/just-symbols-cref.s
index 4aad58ccf36f7..c58e0ce9d6dde 100644
--- a/lld/test/ELF/just-symbols-cref.s
+++ b/lld/test/ELF/just-symbols-cref.s
@@ -3,7 +3,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
 # RUN: ld.lld %t.o -o %t1.exe -Ttext=0x10000
 
-# RUN: ld.lld -just-symbols=%t1.exe -o %t2.exe -cref | FileCheck %s
+# RUN: ld.lld --just-symbols=%t1.exe -o %t2.exe --cref | FileCheck %s
 
 # CHECK:      Symbol      File
 # CHECK-NEXT: foo         {{.*exe}}