[PATCH] D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS

Aaron Puchert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 20 14:21:15 PDT 2021


aaronpuchert added a comment.

In D96670#2819765 <https://reviews.llvm.org/D96670#2819765>, @dsanders wrote:

> I'm not familiar with the behaviour of cmake exports so I don't feel able to review this

I think I saw your name in the `git blame`. There isn't much to know about the exports here, except that there is the possibility to ship a big shared library that contains all LLVM components, and Linux distributions want LLVM users to link against that instead of the individual component libraries. So often the component libraries are not even shipped.

Subsequently, some of the targets that exist in-tree are not available to external users. That's not a problem, as `llvm_map_components_to_libnames` maps these components to the shared library in that case, but without this patch it doesn't expand pseudo-components when their constituents are not targets.

> I don't think it changes whether you run into the problem or not but is there a reason dragonffi specifies ${LLVM_NATIVE_ARCH} rather than `native`?

Not sure. But it seems to me as well that it wouldn't change anything, one is just an alias for the other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96670/new/

https://reviews.llvm.org/D96670



More information about the llvm-commits mailing list