[PATCH] D104571: [WebAssembly] Make tag attribute's encoding uint8

[Thomas Lively via Phabricator via llvm-commits]

tlively accepted this revision.
tlively added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:817
     case wasm::WASM_EXTERNAL_TAG:
-      encodeULEB128(Import.Tag.Attribute, W->OS);
+      W->OS << char(Import.Tag.Attribute);
       encodeULEB128(Import.Tag.SigIndex, W->OS);
----------------
Normally I would suggest using `uint8_t` rather than `char` here, but I see that this file already uses `char` in many places, so it's probably best to stay consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104571/new/

https://reviews.llvm.org/D104571