[PATCH] D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW.

Sat Jun 19 22:53:55 PDT 2021

LuoYuanke added a comment.

> Are you running the large and small cases the same way? Have looked at the SelectionDAG debug logs for the affected basic block in the large case?
>
> I was able to trigger the error with llc -O2 -fast-isel on a simple test. So that is a path to create this but you haven’t answered if fast isel is being used in your case.

Not exact the same way. For large case, I run through ld.lld and with some options like this "-plugin-opt=mcpu=x86-64 -plugin-opt=O3 <https://reviews.llvm.org/owners/package/3/>". For small case, I assembly the -plugin-opt and use llc to run it. Since I use O3 <https://reviews.llvm.org/owners/package/3/>, so I think it won't run fastISel. However, I'll check fastISel in large case.

Do you have a patch to fix fast ISel, so that I can verify your patch in my large case?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104440/new/

https://reviews.llvm.org/D104440