[PATCH] D102972: [lld-macho][nfc] Sort OutputSections based on explicit order of command-line inputs

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 19 07:33:33 PDT 2021


thakis added inline comments.


================
Comment at: lld/MachO/OutputSection.h:64
+  // contain.
+  int inputOrder = std::numeric_limits<int>::max();
 
----------------
This is a dangerous default that is almost always wrong in practice since it makes every section compete with BSS sections (which _must_ be last). See https://bugs.llvm.org/show_bug.cgi?id=50769#c5


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102972/new/

https://reviews.llvm.org/D102972



More information about the llvm-commits mailing list