[PATCH] D104569: [SimplifyCFG] Fix SimplifyBranchOnICmpChain to be undef/poison safe.

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 19 07:32:40 PDT 2021


aqjune added a comment.

In favor of this patch, I'll abandon mine; I'm occupied with something else ATM :/
@hyeongyukim Do you want to see how many assembly files from llvm testsuite are affected by this patch? If there is a significant assembly change, you'd like to see which pass is blocked by this.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:4267
+    // UB. It can be solved by adding freeze instruction to extra values.
+    if (!isGuaranteedNotToBeUndefOrPoison(ExtraCase))
+      ExtraCase = Builder.CreateFreeze(ExtraCase);
----------------
Is it possible to pass a dominator tree to this function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104569/new/

https://reviews.llvm.org/D104569



More information about the llvm-commits mailing list