[PATCH] D104576: RegisterCoalescer: Fix iterating through use operands.

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Just so that I understand clearly, the fault here was modifying operands while using range-iteration over the same collection? Was the symptom a crash, or missing output? (Thanks for the catch).



================
Comment at: llvm/test/DebugInfo/MIR/X86/regcoalescer.mir:45
+    DBG_VALUE %0, _, !18, !DIExpression(), debug-location !21
+    DBG_VALUE %0, _, !19, !DIExpression(), debug-location !22
+    $eax = COPY killed %0, debug-location !22
----------------
Should this not lead to an additional DBG_VALUE in output, and an additional CHECK line for it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104576/new/

https://reviews.llvm.org/D104576