[PATCH] D72223: [MLIR] Introduce affine.execute_region op

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 19 02:35:19 PDT 2021


bondhugula added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Affine/IR/AffineOps.td:656
+      affine.for %i = 0 to %n {
+        affine.execute_region [] = () : () -> () {
+          // %pow can now be used as a loop bound.
----------------
ftynse wrote:
> Syntax nit: I'd consider omitting empty `[] = ()`, looks distracting
@ftynse Unfortunately, the parser API won't support this unless we want to disallow `[] = ()` and even there we won't be able to emit the right error message. (Basically we won't know whether to parse the `=`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72223/new/

https://reviews.llvm.org/D72223



More information about the llvm-commits mailing list